rpc_server: Fix CID 1311342 Null pointer dereferences (REVERSE_INULL)
authorVolker Lendecke <vl@samba.org>
Thu, 9 Jul 2015 17:30:07 +0000 (19:30 +0200)
committerRalph Böhme <slow@samba.org>
Thu, 9 Jul 2015 23:01:36 +0000 (01:01 +0200)
elem was dereferenced already a few lines above

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Fri Jul 10 01:01:36 CEST 2015 on sn-devel-104

source3/rpc_server/mdssvc/mdssvc.c

index 3f7da49ea20f67cde09a8e71a6db9a39930c7054..abfea433e05c722c7c4e15afb9c8f292f1699d09 100644 (file)
@@ -1656,9 +1656,7 @@ static bool slrpc_fetch_attributes(struct mds_ctx *mds_ctx,
                goto error;
        }
 
-       ok = add_filemeta(reqinfo, fm_array,
-                         elem ? elem->path : NULL,
-                         elem ? &sb : NULL);
+       ok = add_filemeta(reqinfo, fm_array, elem->path, &sb);
        if (!ok) {
                goto error;
        }