ctdb-common: replace talloc / memcpy by talloc_memdup
authorSwen Schillig <swen@vnet.ibm.com>
Wed, 7 Mar 2018 13:40:33 +0000 (14:40 +0100)
committerMartin Schwenke <martins@samba.org>
Fri, 22 Jun 2018 09:57:19 +0000 (11:57 +0200)
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Jun 22 11:57:19 CEST 2018 on sn-devel-144

ctdb/common/ctdb_io.c

index 3e732e8527d9cbaa928aa95df2e309d1d1ae48b2..c6941241883c18c05671ba1d305c2745efeee95a 100644 (file)
@@ -117,12 +117,11 @@ static void queue_process(struct ctdb_queue *queue)
        }
 
        /* Extract complete packet */
-       data = talloc_size(queue, pkt_size);
+       data = talloc_memdup(queue, queue->buffer.data, pkt_size);
        if (data == NULL) {
-               DEBUG(DEBUG_ERR, ("read error alloc failed for %u\n", pkt_size));
+               D_ERR("read error alloc failed for %u\n", pkt_size);
                return;
        }
-       memcpy(data, queue->buffer.data, pkt_size);
 
        /* Shift packet out from buffer */
        if (queue->buffer.length > pkt_size) {