drm/i915/display: Mark conn as initialised by iterator
authorChris Wilson <chris@chris-wilson.co.uk>
Mon, 28 Oct 2019 14:26:52 +0000 (14:26 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Mon, 28 Oct 2019 16:09:44 +0000 (16:09 +0000)
smatch complains about
drivers/gpu/drm/i915//display/intel_display.c:14403 intel_set_dp_tp_ctl_normal() error: uninitialized symbol 'conn'.
because it has no way to determine that the loop must have an entry.
Tell the static analysers to ignore the local, it will always be set.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191028142652.1987-2-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/display/intel_display.c

index 0f0c582a56d593ca0942681f133fe61ef08f278b..9dce2e9e53768735eb963a348e2f21bd6f062828 100644 (file)
@@ -14391,8 +14391,8 @@ static void intel_crtc_enable_trans_port_sync(struct intel_crtc *crtc,
 static void intel_set_dp_tp_ctl_normal(struct intel_crtc *crtc,
                                       struct intel_atomic_state *state)
 {
+       struct drm_connector *uninitialized_var(conn);
        struct drm_connector_state *conn_state;
-       struct drm_connector *conn;
        struct intel_dp *intel_dp;
        int i;