KCC: add a warning about side-effects in RepsFromTo.__setattr__

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/python/samba/kcc/kcc_utils.py b/python/samba/kcc/kcc_utils.py
index 2f6eed7d188e16f03013d79e77deee04b09018a5..f20122e9dd33a633330d21bc2111a3ebafd8a683 100644 (file)
--- a/python/samba/kcc/kcc_utils.py
+++ b/python/samba/kcc/kcc_utils.py
@@ -1915,7 +1915,11 @@ class RepsFromTo(object):
         return text
 
     def __setattr__(self, item, value):
+        """Set an attribute and chyange update flag.
 
+        Be aware that setting any RepsFromTo attribute will set the
+        drsuapi.DRSUAPI_DRS_UPDATE_ADDRESS update flag.
+        """
         if item in ['schedule', 'replica_flags', 'transport_guid',
                     'source_dsa_obj_guid', 'source_dsa_invocation_id',
                     'consecutive_sync_failures', 'last_success',