drm/nouveau/kms: Remove redundant zpos initialisation
authorMaxime Ripard <maxime@cerno.tech>
Mon, 21 Feb 2022 09:59:09 +0000 (10:59 +0100)
committerMaxime Ripard <maxime@cerno.tech>
Fri, 25 Feb 2022 16:56:48 +0000 (17:56 +0100)
The nouveau KMS driver will call drm_plane_create_zpos_property() with
an init value depending on the plane purpose.

Since the initial value wasn't carried over in the state, the driver had
to set it again in nv50_wndw_reset(). However, the helpers have been
adjusted to set it properly at reset, so this is not needed anymore.

Cc: nouveau@lists.freedesktop.org
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220221095918.18763-14-maxime@cerno.tech
drivers/gpu/drm/nouveau/dispnv50/wndw.c

index 133c8736426a9eefd4e0a1de57f3e71451626dac..0c1a2ea0ed04a933fe7bd6d5d4b80586126ed926 100644 (file)
@@ -635,8 +635,6 @@ nv50_wndw_reset(struct drm_plane *plane)
                plane->funcs->atomic_destroy_state(plane, plane->state);
 
        __drm_atomic_helper_plane_reset(plane, &asyw->state);
-       plane->state->zpos = nv50_wndw_zpos_default(plane);
-       plane->state->normalized_zpos = nv50_wndw_zpos_default(plane);
 }
 
 static void