ctdb-tests: Fix error return for ctdb_client_async_control_stub()
authorMartin Schwenke <martin@meltin.net>
Tue, 17 Mar 2015 09:14:08 +0000 (20:14 +1100)
committerAmitay Isaacs <amitay@samba.org>
Mon, 23 Mar 2015 11:23:12 +0000 (12:23 +0100)
It should be -1 even without a failure callback registered.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb/tests/src/ctdb_test_stubs.c

index 17a1b067191b9d4b209eb5f665162a1585ea5f7f..eb36d9b8fe87efd7e93890e8e38bb5b63376d0a9 100644 (file)
@@ -852,9 +852,9 @@ ctdb_client_async_control_stub(struct ctdb_context *ctdb,
                                client_callback(ctdb, pnn, res, outdata, callback_data);
                        }
                } else {
+                       ret = -1;
                        if (fail_callback != NULL) {
                                fail_callback(ctdb, pnn, res, outdata, callback_data);
-                               ret = -1;
                        }
                }
        }