perf_counter tools: Initialize a stack variable before use
authorArjan van de Ven <arjan@linux.intel.com>
Sat, 6 Jun 2009 19:22:33 +0000 (21:22 +0200)
committerIngo Molnar <mingo@elte.hu>
Sat, 6 Jun 2009 19:22:33 +0000 (21:22 +0200)
the "perf report" utility crashed in some circumstances
because the "sym" stack variable was not initialized before used
(as also proven by valgrind).

With this fix both the crash goes away and valgrind no longer complains.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
tools/perf/util/symbol.c

index 253821d1efdb8c9734823f7722a0add17275af90..158588c7f6b1daedd7c6aa659da82beb0c238566 100644 (file)
@@ -457,6 +457,8 @@ static int dso__load_sym(struct dso *self, int fd, const char *name,
 
        nr_syms = shdr.sh_size / shdr.sh_entsize;
 
+       memset(&sym, 0, sizeof(sym));
+
        elf_symtab__for_each_symbol(syms, nr_syms, index, sym) {
                struct symbol *f;
                uint64_t obj_start;