s3/vfs_glusterfs: Avoid using NAME_MAX directly
authorGünther Deschner <gd@samba.org>
Mon, 3 Jun 2019 14:25:46 +0000 (16:25 +0200)
committerGünther Deschner <gd@samba.org>
Mon, 10 Jun 2019 23:14:11 +0000 (23:14 +0000)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13872

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
source3/modules/vfs_glusterfs.c

index ba8973fa6d3ca97fa8ee8a084a1267c69670358a..a9415952b4e6d99c91991ecefe1fee80083aea22 100644 (file)
@@ -47,6 +47,7 @@
 #include "modules/posixacl_xattr.h"
 
 #define DEFAULT_VOLFILE_SERVER "localhost"
+#define GLUSTER_NAME_MAX 255
 
 static int read_fd = -1;
 static int write_fd = -1;
@@ -1457,18 +1458,19 @@ static int vfs_gluster_get_real_filename(struct vfs_handle_struct *handle,
                                         TALLOC_CTX *mem_ctx, char **found_name)
 {
        int ret;
-       char key_buf[NAME_MAX + 64];
-       char val_buf[NAME_MAX + 1];
+       char key_buf[GLUSTER_NAME_MAX + 64];
+       char val_buf[GLUSTER_NAME_MAX + 1];
 
-       if (strlen(name) >= NAME_MAX) {
+       if (strlen(name) >= GLUSTER_NAME_MAX) {
                errno = ENAMETOOLONG;
                return -1;
        }
 
-       snprintf(key_buf, NAME_MAX + 64,
+       snprintf(key_buf, GLUSTER_NAME_MAX + 64,
                 "glusterfs.get_real_filename:%s", name);
 
-       ret = glfs_getxattr(handle->data, path, key_buf, val_buf, NAME_MAX + 1);
+       ret = glfs_getxattr(handle->data, path, key_buf, val_buf,
+                           GLUSTER_NAME_MAX + 1);
        if (ret == -1) {
                if (errno == ENOATTR) {
                        errno = EOPNOTSUPP;