x86/kvm/hyper-v: Introduce nested_get_evmcs_version() helper
authorVitaly Kuznetsov <vkuznets@redhat.com>
Mon, 10 Dec 2018 17:21:55 +0000 (18:21 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 14 Dec 2018 16:59:54 +0000 (17:59 +0100)
The upcoming KVM_GET_SUPPORTED_HV_CPUID ioctl will need to return
Enlightened VMCS version in HYPERV_CPUID_NESTED_FEATURES.EAX when
it was enabled.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/include/asm/kvm_host.h
arch/x86/kvm/svm.c
arch/x86/kvm/vmx/evmcs.c
arch/x86/kvm/vmx/evmcs.h
arch/x86/kvm/vmx/nested.c

index fbda5a917c5b772dca40724bb2c24c189c38be91..f5c2ce4f01e822236ba28f2dcb402210b6ce3108 100644 (file)
@@ -1186,6 +1186,7 @@ struct kvm_x86_ops {
 
        int (*nested_enable_evmcs)(struct kvm_vcpu *vcpu,
                                   uint16_t *vmcs_version);
+       uint16_t (*nested_get_evmcs_version)(struct kvm_vcpu *vcpu);
 };
 
 struct kvm_arch_async_pf {
index 3cbe67a31c545cd64a8e1034773bbf8dd4ca14bb..0762e81e0498a48d216c34117b56d01be9d95a22 100644 (file)
@@ -7047,6 +7047,12 @@ failed:
        return ret;
 }
 
+static uint16_t nested_get_evmcs_version(struct kvm_vcpu *vcpu)
+{
+       /* Not supported */
+       return 0;
+}
+
 static int nested_enable_evmcs(struct kvm_vcpu *vcpu,
                                   uint16_t *vmcs_version)
 {
@@ -7185,6 +7191,7 @@ static struct kvm_x86_ops svm_x86_ops __ro_after_init = {
        .mem_enc_unreg_region = svm_unregister_enc_region,
 
        .nested_enable_evmcs = nested_enable_evmcs,
+       .nested_get_evmcs_version = nested_get_evmcs_version,
 };
 
 static int __init svm_init(void)
index 155fb4a39472dfef6eb87e0141878456152d2bb2..95bc2247478d90bda1d9305f11986f85db908e5b 100644 (file)
@@ -313,19 +313,28 @@ void evmcs_sanitize_exec_ctrls(struct vmcs_config *vmcs_conf)
 }
 #endif
 
+uint16_t nested_get_evmcs_version(struct kvm_vcpu *vcpu)
+{
+       struct vcpu_vmx *vmx = to_vmx(vcpu);
+       /*
+        * vmcs_version represents the range of supported Enlightened VMCS
+        * versions: lower 8 bits is the minimal version, higher 8 bits is the
+        * maximum supported version. KVM supports versions from 1 to
+        * KVM_EVMCS_VERSION.
+        */
+       if (vmx->nested.enlightened_vmcs_enabled)
+               return (KVM_EVMCS_VERSION << 8) | 1;
+
+       return 0;
+}
+
 int nested_enable_evmcs(struct kvm_vcpu *vcpu,
                        uint16_t *vmcs_version)
 {
        struct vcpu_vmx *vmx = to_vmx(vcpu);
 
-       /*
-        * vmcs_version represents the range of supported Enlightened VMCS
-        * versions: lower 8 bits is the minimal version, higher 8 bits is the
-        * maximum supported version. KVM supports versions from 1 to
-        * KVM_EVMCS_VERSION.
-        */
        if (vmcs_version)
-               *vmcs_version = (KVM_EVMCS_VERSION << 8) | 1;
+               *vmcs_version = nested_get_evmcs_version(vcpu);
 
        /* We don't support disabling the feature for simplicity. */
        if (vmx->nested.enlightened_vmcs_enabled)
index 1572a3759d65894a3038ff964102df7274cbfcac..e0fcef85b3329478e0ded0188b5fff8b93ca8388 100644 (file)
@@ -195,6 +195,7 @@ static inline void evmcs_sanitize_exec_ctrls(struct vmcs_config *vmcs_conf) {}
 static inline void evmcs_touch_msr_bitmap(void) {}
 #endif /* IS_ENABLED(CONFIG_HYPERV) */
 
+uint16_t nested_get_evmcs_version(struct kvm_vcpu *vcpu);
 int nested_enable_evmcs(struct kvm_vcpu *vcpu,
                        uint16_t *vmcs_version);
 
index 70e6d604c2a0d1ad7c48f1f402a9c0ba953d4cde..bb3a7030eb391a898d8aa31d58d7d0d5bf71f797 100644 (file)
@@ -5669,6 +5669,7 @@ __init int nested_vmx_hardware_setup(int (*exit_handlers[])(struct kvm_vcpu *))
        kvm_x86_ops->set_nested_state = vmx_set_nested_state;
        kvm_x86_ops->get_vmcs12_pages = nested_get_vmcs12_pages,
        kvm_x86_ops->nested_enable_evmcs = nested_enable_evmcs;
+       kvm_x86_ops->nested_get_evmcs_version = nested_get_evmcs_version;
 
        return 0;
 }