block: aoe: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 Jun 2019 19:47:54 +0000 (21:47 +0200)
committerJens Axboe <axboe@kernel.dk>
Tue, 4 Jun 2019 19:38:23 +0000 (13:38 -0600)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: "Ed L. Cashin" <ed.cashin@acm.org>
Cc: linux-block@vger.kernel.org
Cc: Omar Sandoval <osandov@osandov.com>
Acked-by: Justin Sanders <justin@coraid.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/aoe/aoeblk.c

index e2c6aae2d63682f4c74faf2d721aec404ee3ffec..bd19f8af950beeb0ecb406ecdddbefcdd9518b35 100644 (file)
@@ -196,7 +196,6 @@ static const struct file_operations aoe_debugfs_fops = {
 static void
 aoedisk_add_debugfs(struct aoedev *d)
 {
-       struct dentry *entry;
        char *p;
 
        if (aoe_debugfs_dir == NULL)
@@ -207,15 +206,8 @@ aoedisk_add_debugfs(struct aoedev *d)
        else
                p++;
        BUG_ON(*p == '\0');
-       entry = debugfs_create_file(p, 0444, aoe_debugfs_dir, d,
-                                   &aoe_debugfs_fops);
-       if (IS_ERR_OR_NULL(entry)) {
-               pr_info("aoe: cannot create debugfs file for %s\n",
-                       d->gd->disk_name);
-               return;
-       }
-       BUG_ON(d->debugfs);
-       d->debugfs = entry;
+       d->debugfs = debugfs_create_file(p, 0444, aoe_debugfs_dir, d,
+                                        &aoe_debugfs_fops);
 }
 void
 aoedisk_rm_debugfs(struct aoedev *d)
@@ -472,10 +464,6 @@ aoeblk_init(void)
        if (buf_pool_cache == NULL)
                return -ENOMEM;
        aoe_debugfs_dir = debugfs_create_dir("aoe", NULL);
-       if (IS_ERR_OR_NULL(aoe_debugfs_dir)) {
-               pr_info("aoe: cannot create debugfs directory\n");
-               aoe_debugfs_dir = NULL;
-       }
        return 0;
 }