s3: Fix 64-bit errors

Casting those variables will lead to sscanf believing that it sees pointers to
unsigned longs. These might be 64 bit long, thus sscanf will overwrite memory
it should not overwrite. Assigning the vars later is okay, there we get
automatic type conversion. C can be nasty ...

Christian, please check!

diff --git a/source3/winbindd/idmap_autorid.c b/source3/winbindd/idmap_autorid.c
index 756c6c29af533b75693bcab7f1ffcdca3dcc8057..ae65647ed63091207b910d476b846149e5800d74 100644 (file)
--- a/source3/winbindd/idmap_autorid.c
+++ b/source3/winbindd/idmap_autorid.c
@@ -395,6 +395,7 @@ static struct autorid_global_config *idmap_autorid_loadconfig(TALLOC_CTX * ctx)
 
        TDB_DATA data;
        struct autorid_global_config *cfg;
+       unsigned long minvalue, rangesize, maxranges;
 
        data = dbwrap_fetch_bystring(autorid_db, ctx, CONFIGKEY);
 
@@ -408,16 +409,19 @@ static struct autorid_global_config *idmap_autorid_loadconfig(TALLOC_CTX * ctx)
                return NULL;
        }
 
-       if (sscanf
-           ((char *)data.dptr, "minvalue:%lu rangesize:%lu maxranges:%lu",
-            (unsigned long *)&cfg->minvalue, (unsigned long *)&cfg->rangesize,
-            (unsigned long *)&cfg->maxranges) != 3) {
+       if (sscanf((char *)data.dptr,
+                  "minvalue:%lu rangesize:%lu maxranges:%lu",
+                  &minvalue, &rangesize, &maxranges) != 3) {
                DEBUG(1,
                      ("Found invalid configuration data"
                       "creating new config\n"));
                return NULL;
        }
 
+       cfg->minvalue = minvalue;
+       cfg->rangesize = rangesize;
+       cfg->maxranges = maxranges;
+
        DEBUG(10, ("Loaded previously stored configuration "
                   "minvalue:%d rangesize:%d\n",
                   cfg->minvalue, cfg->rangesize));