Thanks to abartlet I looked at that function a bit closer. What did

the first cli_push_string do? I suspect that it's a leftover from times
when the password length was needed at some point.

Volker

diff --git a/source/libsmb/cliconnect.c b/source/libsmb/cliconnect.c
index ebadafd5f05f4a71012c8ab301b177f7e708c60d..695c6506b5de5d637c2f24e0f28ace8ecd2b110a 100644 (file)
--- a/source/libsmb/cliconnect.c
+++ b/source/libsmb/cliconnect.c
@@ -184,10 +184,7 @@ static BOOL cli_session_setup_plaintext(struct cli_state *cli, char *user,
                                        char *pass, char *workgroup)
 {
        uint32 capabilities = cli_session_setup_capabilities(cli);
-       fstring pword;
-       int passlen;
        char *p;
-
        int push_flags = STR_TERMINATE;
 
        if (capabilities & CAP_UNICODE)
@@ -195,8 +192,6 @@ static BOOL cli_session_setup_plaintext(struct cli_state *cli, char *user,
        else
                push_flags |= STR_ASCII;
 
-       passlen = clistr_push(cli, pword, pass, sizeof(pword), push_flags);
-
        set_message(cli->outbuf,13,0,True);
        SCVAL(cli->outbuf,smb_com,SMBsesssetupX);
        cli_setup_packet(cli);