dbwrap_ctdb: simplify if condition

This just moves the talloc_memdup() out of the if condition as per
README.Coding.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/source3/lib/dbwrap/dbwrap_ctdb.c b/source3/lib/dbwrap/dbwrap_ctdb.c
index a5f27658a031065e61a183efca025fa3e8da3904..b8fedb7dcd2f4be33687aa06882205f4fa678bd6 100644 (file)
--- a/source3/lib/dbwrap/dbwrap_ctdb.c
+++ b/source3/lib/dbwrap/dbwrap_ctdb.c
@@ -1232,12 +1232,14 @@ again:
        result->value.dsize = ctdb_data.dsize - sizeof(crec->header);
        result->value.dptr = NULL;
 
-       if ((result->value.dsize != 0)
-           && !(result->value.dptr = (uint8_t *)talloc_memdup(
-                        result, ctdb_data.dptr + sizeof(crec->header),
-                        result->value.dsize))) {
-               DEBUG(0, ("talloc failed\n"));
-               TALLOC_FREE(result);
+       if (result->value.dsize != 0) {
+               result->value.dptr = talloc_memdup(
+                       result, ctdb_data.dptr + sizeof(crec->header),
+                       result->value.dsize);
+               if (result->value.dptr == NULL) {
+                       DBG_ERR("talloc failed\n");
+                       TALLOC_FREE(result);
+               }
        }
 
        SAFE_FREE(ctdb_data.dptr);