USB: fix ratelimit call semantics
authorAlan Stern <stern@rowland.harvard.edu>
Tue, 22 May 2007 15:48:17 +0000 (11:48 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 23 May 2007 06:45:50 +0000 (23:45 -0700)
This patch (as910) fixes a ratelimit modification so that the
original error-handling path will be followed even when the log-rate
limitation kicks in.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/core/hub.c

index 6a6e4f8c69ba5b9efa911e88ff85f0d345c9d657..caaa46f2dec724214ca33fc476058aee6d93a7df 100644 (file)
@@ -2421,10 +2421,10 @@ static void hub_port_connect_change(struct usb_hub *hub, int port1,
 
        if (portchange & USB_PORT_STAT_C_CONNECTION) {
                status = hub_port_debounce(hub, port1);
-               if (status < 0 && printk_ratelimit()) {
-                       dev_err (hub_dev,
-                               "connect-debounce failed, port %d disabled\n",
-                               port1);
+               if (status < 0) {
+                       if (printk_ratelimit())
+                               dev_err (hub_dev, "connect-debounce failed, "
+                                               "port %d disabled\n", port1);
                        goto done;
                }
                portstatus = status;