This is how combination of domain logons and security parameter best combine.

Comments wellcome.

Simo.
(This used to be commit e1431424e7603d946f63cfe7fe669b0b32ac8095)

diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c
index f7f12bbe806bf1ac43fcfee13eb804f4726d03dc..2a83905a9f6e2c4fa6a121a0ecf6e449f0d65dbb 100644 (file)
--- a/source3/param/loadparm.c
+++ b/source3/param/loadparm.c
@@ -3804,14 +3804,14 @@ static void set_server_role(void)
 
        switch (lp_security()) {
                case SEC_SHARE:
+               case SEC_SERVER:
+               case SEC_ADS:
                        if (lp_domain_logons())
                                DEBUG(0, ("Server's Role (logon server) conflicts with share-level security\n"));
                        break;
-               case SEC_SERVER:
                case SEC_DOMAIN:
-               case SEC_ADS:
                        if (lp_domain_logons()) {
-                               server_role = ROLE_DOMAIN_PDC;
+                               server_role = ROLE_DOMAIN_BDC;
                                break;
                        }
                        server_role = ROLE_DOMAIN_MEMBER;