objtool: Add a comment for the unreachable annotation macros
authorJosh Poimboeuf <jpoimboe@redhat.com>
Mon, 6 Nov 2017 13:17:37 +0000 (07:17 -0600)
committerIngo Molnar <mingo@kernel.org>
Tue, 7 Nov 2017 09:48:22 +0000 (10:48 +0100)
Add a comment for the unreachable annotation macros to explain their
purpose and the '__COUNTER__' label hack.

Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1570e48d9f87e0fc6f0126c32e7e1de6e109cb67.1509974104.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
include/linux/compiler.h

index 202710420d6deba1bba8107616359ae069ffd5e7..f8734fca54ce1572b9ad175d36c2f5a9d8202521 100644 (file)
@@ -187,6 +187,11 @@ void ftrace_likely_update(struct ftrace_likely_data *f, int val,
 
 /* Unreachable code */
 #ifdef CONFIG_STACK_VALIDATION
+/*
+ * These macros help objtool understand GCC code flow for unreachable code.
+ * The __COUNTER__ based labels are a hack to make each instance of the macros
+ * unique, to convince GCC not to merge duplicate inline asm statements.
+ */
 #define annotate_reachable() ({                                                \
        asm("%c0:\n\t"                                                  \
            ".pushsection .discard.reachable\n\t"                       \