Fix pdb_samba_dsdb build on Ubuntu 16.04 with -O3 -Werror=strict-overflow

../source3/passdb/pdb_samba_dsdb.c: In function ‘pdb_samba_dsdb_set_trusteddom_pw’:
../source3/passdb/pdb_samba_dsdb.c:2778:6: error: assuming signed overflow does not occur when simplifying conditional to constant [-Werror=strict-overflow]
   if (i == 0) {
      ^
cc1: all warnings being treated as errors

gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10)

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Sep 20 01:29:48 CEST 2018 on sn-devel-144

diff --git a/source3/passdb/pdb_samba_dsdb.c b/source3/passdb/pdb_samba_dsdb.c
index f405c51aaebd1ee48a9b16b366b38e169ea49895..2f655c7c79a801766b5fc7e1e436b8cbc159f7d6 100644 (file)
--- a/source3/passdb/pdb_samba_dsdb.c
+++ b/source3/passdb/pdb_samba_dsdb.c
@@ -2603,7 +2603,7 @@ static bool pdb_samba_dsdb_set_trusteddom_pw(struct pdb_methods *m,
        struct ldb_message *msg = NULL;
        int trust_direction_flags;
        int trust_type;
-       int i;
+       uint32_t i; /* The same type as old_blob.current.count */
        const struct ldb_val *old_val = NULL;
        struct trustAuthInOutBlob old_blob = {};
        uint32_t old_version = 0;