media: imx214: Remove unnecessary self assignment in for loop
authorNathan Chancellor <natechancellor@gmail.com>
Wed, 7 Nov 2018 06:24:50 +0000 (01:24 -0500)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 23 Nov 2018 09:41:41 +0000 (04:41 -0500)
Clang warns when a variable is assigned to itself:

drivers/media/i2c/imx214.c:695:13: error: explicitly assigning value of
variable of type 'const struct reg_8 *' to itself
[-Werror,-Wself-assign]
        for (table = table; table->addr != IMX214_TABLE_END ; table++) {
             ~~~~~ ^ ~~~~~
1 error generated.

Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/i2c/imx214.c

index 284b9b49ebde8e197633ff6750b3328435303dd2..ec3d1b855f623a0f4e767b845106b11a4cedd787 100644 (file)
@@ -692,7 +692,7 @@ static int imx214_write_table(struct imx214 *imx214,
        int i;
        int ret;
 
-       for (table = table; table->addr != IMX214_TABLE_END ; table++) {
+       for (; table->addr != IMX214_TABLE_END ; table++) {
                if (table->addr == IMX214_TABLE_WAIT_MS) {
                        usleep_range(table->val * 1000,
                                     table->val * 1000 + 500);