[media] DaVinci-VPBE: Return the success indication only as a constant in vpbe_set_mode()

* Return a success code without storing it in an intermediate variable.

* Delete the local variable "ret" which became unnecessary with
  this refactoring.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media/platform/davinci/vpbe.c
index 3ac4ba35832a899d9fd36b32798dd29e1579d091..50b9e3df68b534040517ce45b5e1a9c59e469aac 100644 (file)
--- a/drivers/media/platform/davinci/vpbe.c
+++ b/drivers/media/platform/davinci/vpbe.c
@@ -509,7 +509,6 @@ static int vpbe_set_mode(struct vpbe_device *vpbe_dev,
        struct v4l2_dv_timings dv_timings;
        struct osd_state *osd_device;
        int out_index = vpbe_dev->current_out_index;
-       int ret = 0;
        int i;
 
        if (!mode_info || !mode_info->name)
@@ -549,8 +548,7 @@ static int vpbe_set_mode(struct vpbe_device *vpbe_dev,
                vpbe_dev->current_timings.upper_margin);
 
        mutex_unlock(&vpbe_dev->lock);
-
-       return ret;
+       return 0;
 }
 
 static int vpbe_set_default_mode(struct vpbe_device *vpbe_dev)