ext4: update ctime when changing the file's permission by setfacl
authorJan Kara <jack@suse.cz>
Tue, 15 Jun 2010 16:19:59 +0000 (12:19 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 15 Jun 2010 16:19:59 +0000 (12:19 -0400)
ext4 didn't update the ctime of the file when its permission was
changed.

Steps to reproduce:
 # touch aaa
 # stat -c %Z aaa
 1275289822
 # setfacl -m  'u::x,g::x,o::x' aaa
 # stat -c %Z aaa
 1275289822                         <- unchanged

But, according to the spec of the ctime, ext4 must update it.

Port of ext3 patch by Miao Xie <miaox@cn.fujitsu.com>.

CC: linux-ext4@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/acl.c

index feaf498feaa68ee709ea216de5ef87b85d209bcd..5e2ed4504eadd85401d9f86d5e3784ecd2e2e7c1 100644 (file)
@@ -204,6 +204,7 @@ ext4_set_acl(handle_t *handle, struct inode *inode, int type,
                                return error;
                        else {
                                inode->i_mode = mode;
+                               inode->i_ctime = ext4_current_time(inode);
                                ext4_mark_inode_dirty(handle, inode);
                                if (error == 0)
                                        acl = NULL;