s3-spoolss: Fix Bug #7641: handle win9x adddriver calls w/o config file.
authorGünther Deschner <gd@samba.org>
Mon, 29 Nov 2010 16:56:40 +0000 (17:56 +0100)
committerGünther Deschner <gd@samba.org>
Mon, 29 Nov 2010 16:56:40 +0000 (17:56 +0100)
This turned cupsaddsmb to run into an infinite loop.

Guenther

source3/printing/nt_printing.c

index 8462c859d233094b97cae7d3243747d4ba0393cc..671aca6a51999b2a4a498d9d3d145ed1b573d5d7 100644 (file)
@@ -761,7 +761,11 @@ static WERROR clean_up_driver_struct_level(TALLOC_CTX *mem_ctx,
        WERROR err;
        char *_p;
 
-       if (!*driver_path || !*data_file || !*config_file) {
+       if (!*driver_path || !*data_file) {
+               return WERR_INVALID_PARAM;
+       }
+
+       if (!strequal(architecture, SPOOLSS_ARCHITECTURE_4_0) && !*config_file) {
                return WERR_INVALID_PARAM;
        }
 
@@ -773,7 +777,9 @@ static WERROR clean_up_driver_struct_level(TALLOC_CTX *mem_ctx,
 
        strip_driver_path(mem_ctx, *driver_path);
        strip_driver_path(mem_ctx, *data_file);
-       strip_driver_path(mem_ctx, *config_file);
+       if (*config_file) {
+               strip_driver_path(mem_ctx, *config_file);
+       }
        if (help_file) {
                strip_driver_path(mem_ctx, *help_file);
        }