r25829: - use DEBUG() instead of printf

- return an error if strings doesn't match on validate

metze
(This used to be commit 4f5ad8cd447f8b44df1bd40f5ee3045d5ab2c3dc)

diff --git a/source4/librpc/rpc/dcerpc.c b/source4/librpc/rpc/dcerpc.c
index 5f7b2991a9d9e19dbaf7ad791807cb1f974e0214..9d58fafcb86dae6e2e96b0d99636b13e42a2a9bd 100644 (file)
--- a/source4/librpc/rpc/dcerpc.c
+++ b/source4/librpc/rpc/dcerpc.c
@@ -1291,7 +1291,7 @@ static NTSTATUS dcerpc_ndr_validate_out(struct dcerpc_connection *c,
                                       NDR_OUT, st);
        if (strcmp(s1, s2) != 0) {
 #if 1
-               printf("VALIDATE ERROR:\nWIRE:\n%s\n GEN:\n%s\n", s1, s2);
+               DEBUG(3,("VALIDATE ERROR:\nWIRE:\n%s\n GEN:\n%s\n", s1, s2));
 #else
                /* this is sometimes useful */
                printf("VALIDATE ERROR\n");
@@ -1299,6 +1299,8 @@ static NTSTATUS dcerpc_ndr_validate_out(struct dcerpc_connection *c,
                file_save("gen.dat", s2, strlen(s2));
                system("diff -u wire.dat gen.dat");
 #endif
+               return ndr_push_error(push, NDR_ERR_VALIDATE,
+                                     "failed output validation strings doesn't match");
        }
 
        return NT_STATUS_OK;