nfsd: "\%s" should be "%s"
authorJ. Bruce Fields <bfields@redhat.com>
Thu, 3 Oct 2019 16:33:08 +0000 (12:33 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Tue, 8 Oct 2019 20:01:33 +0000 (16:01 -0400)
Randy says:
> sparse complains about these, as does gcc when used with --pedantic.
> sparse says:
>
> ../fs/nfsd/nfs4state.c:2385:23: warning: unknown escape sequence: '\%'
> ../fs/nfsd/nfs4state.c:2385:23: warning: unknown escape sequence: '\%'
> ../fs/nfsd/nfs4state.c:2388:23: warning: unknown escape sequence: '\%'
> ../fs/nfsd/nfs4state.c:2388:23: warning: unknown escape sequence: '\%'

I'm not sure how this crept in.  Fix it.

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4state.c

index c65aeaa812d42889c34bc655cadbdbf212c26054..befcafc43c742f1e48dd1a8ed016d8f8dc1c9a5f 100644 (file)
@@ -2382,10 +2382,10 @@ static int nfs4_show_open(struct seq_file *s, struct nfs4_stid *st)
        access = bmap_to_share_mode(ols->st_access_bmap);
        deny   = bmap_to_share_mode(ols->st_deny_bmap);
 
-       seq_printf(s, "access: \%s\%s, ",
+       seq_printf(s, "access: %s%s, ",
                access & NFS4_SHARE_ACCESS_READ ? "r" : "-",
                access & NFS4_SHARE_ACCESS_WRITE ? "w" : "-");
-       seq_printf(s, "deny: \%s\%s, ",
+       seq_printf(s, "deny: %s%s, ",
                deny & NFS4_SHARE_ACCESS_READ ? "r" : "-",
                deny & NFS4_SHARE_ACCESS_WRITE ? "w" : "-");