s4-torture/drs: Use addCleanup() in getchanges.py for OU handling
authorAndrew Bartlett <abartlet@samba.org>
Sun, 23 Jul 2023 23:37:19 +0000 (11:37 +1200)
committerJule Anger <janger@samba.org>
Fri, 18 Aug 2023 09:17:13 +0000 (09:17 +0000)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15401

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 40f831e67e1f312b1db52c74c119899245d03e32)

source4/torture/drs/python/getncchanges.py

index 2095bc61a7738fd7ca84186029c8b45ecf96ec74..46598311f797e1a698f603083dea7b68ddfe755a 100644 (file)
@@ -51,21 +51,13 @@ class DrsReplicaSyncIntegrityTestCase(drs_base.DrsBaseTestCase):
         self.ou = str(samba.tests.create_test_ou(self.test_ldb_dc,
                                                  "getncchanges." + self.id().rsplit(".", 1)[1]))
 
+        self.addCleanup(self.ldb_dc2.delete, self.ou, ["tree_delete:1"])
+
         self.base_dn = self.test_ldb_dc.get_default_basedn()
 
         self.default_conn = DcConnection(self, self.ldb_dc2, self.dnsname_dc2)
         self.set_dc_connection(self.default_conn)
 
-    def tearDown(self):
-        super(DrsReplicaSyncIntegrityTestCase, self).tearDown()
-        # tidyup groups and users
-        try:
-            self.ldb_dc2.delete(self.ou, ["tree_delete:1"])
-        except ldb.LdbError as e:
-            (enum, string) = e.args
-            if enum == ldb.ERR_NO_SUCH_OBJECT:
-                pass
-
     def init_test_state(self):
         self.rxd_dn_list = []
         self.rxd_links = []