r16608: Klocwork #2035. Null deref (bit of a stretch... :-).

Jeremy.
(This used to be commit 7d7a98208b1b514da60486fcbbb7b6d04df4ffac)

diff --git a/source3/client/smbspool.c b/source3/client/smbspool.c
index e5cd4f2e8e6573c5eaa0a8087102f218aa83c82d..c9a7fbe10efc8beeeaa2cbdab2335538a5e6d20d 100644 (file)
--- a/source3/client/smbspool.c
+++ b/source3/client/smbspool.c
@@ -72,6 +72,7 @@ static int            smb_print(struct cli_state *, char *, FILE *);
   struct cli_state *cli;       /* SMB interface */
   char null_str[1];
   int tries = 0;
+  const char *dev_uri;
 
   null_str[0] = '\0';
 
@@ -132,8 +133,9 @@ static int          smb_print(struct cli_state *, char *, FILE *);
   * Find the URI...
   */
 
-  if (getenv("DEVICE_URI") != NULL)
-    strncpy(uri, getenv("DEVICE_URI"), sizeof(uri) - 1);
+  dev_uri = getenv("DEVICE_URI");
+  if (dev_uri)
+    strncpy(uri, dev_uri, sizeof(uri) - 1);
   else if (strncmp(argv[0], "smb://", 6) == 0)
     strncpy(uri, argv[0], sizeof(uri) - 1);
   else