smbdotconf: mark "change share command" with substitution="1"
authorRalph Boehme <slow@samba.org>
Mon, 4 Nov 2019 14:24:16 +0000 (15:24 +0100)
committerStefan Metzmacher <metze@samba.org>
Wed, 27 Nov 2019 10:25:34 +0000 (10:25 +0000)
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
docs-xml/smbdotconf/misc/changesharecommand.xml
source3/rpc_server/srvsvc/srv_srvsvc_nt.c

index 9f805b138a7203d79ef0bda69f6847b23135e4a1..4cc74515376c0c6e9f4dbfcbc9a7fc6a3d2cc349 100644 (file)
@@ -1,6 +1,7 @@
 <samba:parameter name="change share command"
                  context="G"
                  type="string"
+                 substitution="1"
                  xmlns:samba="http://www.samba.org/samba/DTD/samba-doc">
 <description>
        <para>
index b3c9211f7a43c531af5636f99264a52b388c05d6..dbb5a2ef991dfcb6b68830c7c63fe2de9938af30 100644 (file)
@@ -1889,7 +1889,7 @@ WERROR _srvsvc_NetShareSetInfo(struct pipes_struct *p,
        string_replace(comment, '"', ' ');
 
        DEBUG(10,("_srvsvc_NetShareSetInfo: change share command = %s\n",
-               lp_change_share_command(talloc_tos()) ? lp_change_share_command(talloc_tos()) : "NULL" ));
+               lp_change_share_command(talloc_tos(), lp_sub) ? lp_change_share_command(talloc_tos(), lp_sub) : "NULL" ));
 
        /* Only call modify function if something changed. */
 
@@ -1898,14 +1898,14 @@ WERROR _srvsvc_NetShareSetInfo(struct pipes_struct *p,
                        || (lp_max_connections(snum) != max_connections)
                        || csc_policy_changed) {
 
-               if (!lp_change_share_command(talloc_tos()) || !*lp_change_share_command(talloc_tos())) {
+               if (!lp_change_share_command(talloc_tos(), lp_sub) || !*lp_change_share_command(talloc_tos(), lp_sub)) {
                        DEBUG(10,("_srvsvc_NetShareSetInfo: No change share command\n"));
                        return WERR_ACCESS_DENIED;
                }
 
                command = talloc_asprintf(p->mem_ctx,
                                "%s \"%s\" \"%s\" \"%s\" \"%s\" %d \"%s\"",
-                               lp_change_share_command(talloc_tos()),
+                               lp_change_share_command(talloc_tos(), lp_sub),
                                get_dyn_CONFIGFILE(),
                                share_name,
                                path,