vdpa: potential uninitialized return in vhost_vdpa_va_map()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 7 Sep 2021 07:32:53 +0000 (10:32 +0300)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 14 Sep 2021 22:10:43 +0000 (18:10 -0400)
The concern here is that "ret" can be uninitialized if we hit the
"goto next" condition on every iteration through the loop.

Fixes: 41ba1b5f9d4b ("vdpa: Support transferring virtual addressing during DMA mapping")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20210907073253.GB18254@kili
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Xie Yongji <xieyongji@bytedance.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
drivers/vhost/vdpa.c

index f41d081777f58b0f8f71b5d4b2a88a1d3a9abb02..35927ceb26ff32bd00476889b2c3e53fa309a8ed 100644 (file)
@@ -640,7 +640,7 @@ static int vhost_vdpa_va_map(struct vhost_vdpa *v,
        u64 offset, map_size, map_iova = iova;
        struct vdpa_map_file *map_file;
        struct vm_area_struct *vma;
-       int ret;
+       int ret = 0;
 
        mmap_read_lock(dev->mm);