r14338: Fix coverity #55 by explicit cast.
authorJeremy Allison <jra@samba.org>
Mon, 13 Mar 2006 18:59:31 +0000 (18:59 +0000)
committerGerald (Jerry) Carter <jerry@samba.org>
Wed, 10 Oct 2007 16:15:25 +0000 (11:15 -0500)
Jeremy.
(This used to be commit 1fece52da4d667fa182aa9a87aaee3917860448b)

source3/rpc_server/srv_svcctl_nt.c

index a0b8b66f508156fee7a0fbfa66975f1913925610..638b66bb9eb7491398a5ed841fe059d7d1c68f0a 100644 (file)
@@ -416,11 +416,14 @@ WERROR _svcctl_enum_services_status(pipes_struct *p, SVCCTL_Q_ENUM_SERVICES_STAT
        if ( !info || (info->type != SVC_HANDLE_IS_SCM) )
                return WERR_BADFID;
                
-       if ( !(info->access_granted & SC_RIGHT_MGR_ENUMERATE_SERVICE) )
+       if ( !(info->access_granted & SC_RIGHT_MGR_ENUMERATE_SERVICE) ) {
                return WERR_ACCESS_DENIED;
+       }
 
-       if ( (num_services = enumerate_status( p->mem_ctx, &services, token )) == -1 )
+       num_services = enumerate_status( p->mem_ctx, &services, token );
+       if (num_services == (uint32)-1 ) {
                return WERR_NOMEM;
+       }
 
         for ( i=0; i<num_services; i++ ) {
                buffer_size += svcctl_sizeof_enum_services_status(&services[i]);