scsi: bnx2fc: Add missing annotation for bnx2fc_abts_cleanup()
authorJules Irenge <jbi.octave@gmail.com>
Sat, 11 Apr 2020 00:19:31 +0000 (01:19 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 24 Apr 2020 16:56:37 +0000 (12:56 -0400)
Sparse reports the following warning:

  warning: context imbalance in bnx2fc_abts_cleanup() - unexpected unlock

The root cause is the missing annotation at bnx2fc_abts_cleanup(). Add the
missing __must_hold(&tgt->tgt_lock) annotation.

Link: https://lore.kernel.org/r/20200411001933.10072-8-jbi.octave@gmail.com
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/bnx2fc/bnx2fc_io.c

index 2b070f0835dfea4ca1c73adca25b411695192d02..1aba5897ccb07e632c252b3316b77c472223dfd0 100644 (file)
@@ -1081,6 +1081,7 @@ int bnx2fc_eh_device_reset(struct scsi_cmnd *sc_cmd)
 }
 
 static int bnx2fc_abts_cleanup(struct bnx2fc_cmd *io_req)
+       __must_hold(&tgt->tgt_lock)
 {
        struct bnx2fc_rport *tgt = io_req->tgt;
        unsigned int time_left;