smbd: Fix an uninitialized memory read
authorVolker Lendecke <vl@samba.org>
Mon, 3 Mar 2014 12:49:46 +0000 (13:49 +0100)
committerMichael Adam <obnox@samba.org>
Mon, 3 Mar 2014 15:30:53 +0000 (16:30 +0100)
This might be the reason for a few flaky builds.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Mon Mar  3 16:30:53 CET 2014 on sn-devel-104

source3/locking/brlock.c

index e6c89490ae3d06a4858530e64a1b9bae5a73ec3c..ac22ba44d9a2f9870f9a2cb357b8e370a1e4a246 100644 (file)
@@ -2085,6 +2085,8 @@ static void brl_get_locks_readonly_parser(TDB_DATA key, TDB_DATA data,
 
        if ((data.dsize % sizeof(struct lock_struct)) == 1) {
                br_lock->have_read_oplocks = (data.dptr[data.dsize-1] == 1);
+       } else {
+               br_lock->have_read_oplocks = false;
        }
 
        DEBUG(10, ("Got %d bytes, have_read_oplocks: %s\n", (int)data.dsize,