s4-libnet: Fix segfault shown by wbinfo --group-info=administrator
authorAndrew Bartlett <abartlet@samba.org>
Mon, 23 Apr 2012 03:47:46 +0000 (13:47 +1000)
committerAndrew Bartlett <abartlet@samba.org>
Mon, 23 Apr 2012 04:12:09 +0000 (06:12 +0200)
The issue was that after the LookupNames call indicated that this was
not a group, the call paths diverged, with both sucess and failure
paths running.

Andrew Bartlett

source4/libnet/libnet_group.c

index 5d8f9e200a818eaa371727ee1e6fdcca8b69c847..b12037e1f388c3d2aa1465b8fdda659485977c5f 100644 (file)
@@ -337,6 +337,7 @@ static void continue_name_found(struct composite_context *ctx)
        if (s->lookup.out.sid_type != SID_NAME_DOM_GRP &&
            s->lookup.out.sid_type != SID_NAME_ALIAS) {
                composite_error(c, NT_STATUS_NO_SUCH_GROUP);
+               return;
        }
 
        /* prepare arguments for groupinfo call */