Update BPKM Auth Reply key length for DOCSIS 3.1
authorPhilip Rosenberg-Watt <p.rosenberg-watt@cablelabs.com>
Thu, 28 Apr 2016 20:25:13 +0000 (14:25 -0600)
committerAnders Broman <a.broman58@gmail.com>
Fri, 29 Apr 2016 04:50:46 +0000 (04:50 +0000)
Wireshark was failing to parse DOCSIS 3.1 BPKM Response (Auth Reply)
messages with a key length of 256 bytes, which is in the DOCSIS 3.1
specification located here:

http://www.cablelabs.com/specification/docsis-3-1-security-specification/

See Appendix I.4 "Authorization Reply"

Change-Id: Ic50eb4a2d637a7bc47385b7c0a96c830f7a920be
Reviewed-on: https://code.wireshark.org/review/15149
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
plugins/docsis/packet-bpkmattr.c

index 618165c40122afec3ef2cbc6b2708ace28945b94..4b707e8d95f11c9d973d4152af9b7a330a012da2 100644 (file)
@@ -190,7 +190,7 @@ dissect_attrs (tvbuff_t * tvb, packet_info * pinfo, proto_tree * tree)
                                  length, ENC_ASCII|ENC_NA);
             break;
           case BPKM_AUTH_KEY:
-            if ((length == 96) || (length == 128))
+            if ((length == 96) || (length == 128) || (length == 256))
               proto_tree_add_item (tree, hf_docsis_bpkmattr_auth_key, tvb, pos,
                                    length, ENC_NA);
             else