Move transfer_file and transfer_file_internal to a module of their own.
authorMichael Adam <obnox@samba.org>
Thu, 10 Jan 2008 13:27:52 +0000 (14:27 +0100)
committerMichael Adam <obnox@samba.org>
Thu, 10 Jan 2008 13:31:25 +0000 (14:31 +0100)
Also, don't auto-generate prototypes of the (two) exported functions
but make a start in having handwritten prototypes in dedicated header
files (not in includes.h ... :-)

Michael
(This used to be commit 395f29d8b768a56af20b37f185eccdc5f37b68d5)

source3/Makefile.in
source3/include/includes.h
source3/include/transfer_file.h [new file with mode: 0644]
source3/lib/util.c
source3/lib/util_transfer_file.c [new file with mode: 0644]

index 71150df7a3b01450b684019de30158d52d2b5707..94c3e7b839157af43f2498039ca22a234bcd9e42 100644 (file)
@@ -290,7 +290,8 @@ LIBSAMBAUTIL_OBJ = $(TALLOC_OBJ) $(LIBREPLACE_OBJ)
 LIB_WITHOUT_PROTO_OBJ = $(LIBREPLACE_OBJ) $(SOCKET_WRAPPER_OBJ) $(NSS_WRAPPER_OBJ) $(TALLOC_OBJ) \
        lib/messages.o librpc/gen_ndr/ndr_messaging.o lib/messages_local.o \
        lib/messages_ctdbd.o lib/packet.o lib/ctdbd_conn.o lib/talloc_stack.o \
-       lib/interfaces.o lib/rbtree.o lib/memcache.o
+       lib/interfaces.o lib/rbtree.o lib/memcache.o \
+       lib/util_transfer_file.o
 
 LIB_WITH_PROTO_OBJ = $(VERSION_OBJ) lib/charcnv.o lib/debug.o lib/fault.o \
          lib/interface.o lib/md4.o \
index 14ef2258e6f4e2cd76843f6857443ded696f0c41..e9477d8ba1620116e73a325e7851b212f3826984 100644 (file)
@@ -811,6 +811,9 @@ enum flush_reason_enum {
 #include "srvstr.h"
 #include "safe_string.h"
 
+/* prototypes from lib/util_transfer_file.c */
+#include "transfer_file.h"
+
 #ifdef __COMPAR_FN_T
 #define QSORT_CAST (__compar_fn_t)
 #endif
diff --git a/source3/include/transfer_file.h b/source3/include/transfer_file.h
new file mode 100644 (file)
index 0000000..79ad9c4
--- /dev/null
@@ -0,0 +1,32 @@
+/*
+ * Unix SMB/CIFS implementation.
+ * Utility functions to transfer files.
+ *
+ * Copyright (C) Michael Adam 2008
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef __TRANSFER_FILE_H__
+#define __TRANSFER_FILE_H__
+
+ssize_t transfer_file_internal(void *in_file,
+                              void *out_file,
+                              size_t n,
+                              ssize_t (*read_fn)(void *, void *, size_t),
+                              ssize_t (*write_fn)(void *, const void *, size_t));
+
+SMB_OFF_T transfer_file(int infd, int outfd, SMB_OFF_T n);
+
+#endif /* __TRANSFER_FILE_H__ */
index 44eaa85ab043b0e3beddfcb79f5e69b5eb55e930..0653fc9d3f30e35c1646244dfce6f27e884eda7a 100644 (file)
@@ -897,93 +897,6 @@ int set_blocking(int fd, bool set)
 #undef FLAG_TO_SET
 }
 
-/****************************************************************************
- Transfer some data between two fd's.
-****************************************************************************/
-
-#ifndef TRANSFER_BUF_SIZE
-#define TRANSFER_BUF_SIZE 65536
-#endif
-
-
-ssize_t transfer_file_internal(void *in_file,
-                              void *out_file,
-                              size_t n,
-                              ssize_t (*read_fn)(void *, void *, size_t),
-                              ssize_t (*write_fn)(void *, void *, size_t))
-{
-       char *buf;
-       size_t total = 0;
-       ssize_t read_ret;
-       ssize_t write_ret;
-       size_t num_to_read_thistime;
-       size_t num_written = 0;
-
-       if ((buf = SMB_MALLOC_ARRAY(char, TRANSFER_BUF_SIZE)) == NULL) {
-               return -1;
-       }
-
-       while (total < n) {
-               num_to_read_thistime = MIN((n - total), TRANSFER_BUF_SIZE);
-
-               read_ret = (*read_fn)(in_file, buf, num_to_read_thistime);
-               if (read_ret == -1) {
-                       DEBUG(0,("transfer_file_internal: read failure. "
-                                "Error = %s\n", strerror(errno) ));
-                       SAFE_FREE(buf);
-                       return -1;
-               }
-               if (read_ret == 0) {
-                       break;
-               }
-
-               num_written = 0;
-
-               while (num_written < read_ret) {
-                       write_ret = (*write_fn)(out_file, buf + num_written,
-                                               read_ret - num_written);
-
-                       if (write_ret == -1) {
-                               DEBUG(0,("transfer_file_internal: "
-                                        "write failure. Error = %s\n",
-                                        strerror(errno) ));
-                               SAFE_FREE(buf);
-                               return -1;
-                       }
-                       if (write_ret == 0) {
-                               return (ssize_t)total;
-                       }
-
-                       num_written += (size_t)write_ret;
-               }
-
-               total += (size_t)read_ret;
-       }
-
-       SAFE_FREE(buf);
-       return (ssize_t)total;
-}
-
-static ssize_t sys_read_fn(void *file, void *buf, size_t len)
-{
-       int *fd = (int *)file;
-
-       return sys_read(*fd, buf, len);
-}
-
-static ssize_t sys_write_fn(void *file, void *buf, size_t len)
-{
-       int *fd = (int *)file;
-
-       return sys_write(*fd, buf, len);
-}
-
-SMB_OFF_T transfer_file(int infd, int outfd, SMB_OFF_T n)
-{
-       return (SMB_OFF_T)transfer_file_internal(&infd, &outfd, (size_t)n,
-                                                sys_read_fn, sys_write_fn);
-}
-
 /*******************************************************************
  Sleep for a specified number of milliseconds.
 ********************************************************************/
diff --git a/source3/lib/util_transfer_file.c b/source3/lib/util_transfer_file.c
new file mode 100644 (file)
index 0000000..1e3b76f
--- /dev/null
@@ -0,0 +1,110 @@
+/*
+ * Unix SMB/CIFS implementation.
+ * Utility functions to transfer files.
+ *
+ * Copyright (C) Jeremy Allison 2001-2002
+ * Copyright (C) Michael Adam 2008
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+
+#include <includes.h>
+
+/****************************************************************************
+ Transfer some data between two fd's.
+****************************************************************************/
+
+#ifndef TRANSFER_BUF_SIZE
+#define TRANSFER_BUF_SIZE 65536
+#endif
+
+
+ssize_t transfer_file_internal(void *in_file,
+                              void *out_file,
+                              size_t n,
+                              ssize_t (*read_fn)(void *, void *, size_t),
+                              ssize_t (*write_fn)(void *, const void *, size_t))
+{
+       char *buf;
+       size_t total = 0;
+       ssize_t read_ret;
+       ssize_t write_ret;
+       size_t num_to_read_thistime;
+       size_t num_written = 0;
+
+       if ((buf = SMB_MALLOC_ARRAY(char, TRANSFER_BUF_SIZE)) == NULL) {
+               return -1;
+       }
+
+       while (total < n) {
+               num_to_read_thistime = MIN((n - total), TRANSFER_BUF_SIZE);
+
+               read_ret = (*read_fn)(in_file, buf, num_to_read_thistime);
+               if (read_ret == -1) {
+                       DEBUG(0,("transfer_file_internal: read failure. "
+                                "Error = %s\n", strerror(errno) ));
+                       SAFE_FREE(buf);
+                       return -1;
+               }
+               if (read_ret == 0) {
+                       break;
+               }
+
+               num_written = 0;
+
+               while (num_written < read_ret) {
+                       write_ret = (*write_fn)(out_file, buf + num_written,
+                                               read_ret - num_written);
+
+                       if (write_ret == -1) {
+                               DEBUG(0,("transfer_file_internal: "
+                                        "write failure. Error = %s\n",
+                                        strerror(errno) ));
+                               SAFE_FREE(buf);
+                               return -1;
+                       }
+                       if (write_ret == 0) {
+                               return (ssize_t)total;
+                       }
+
+                       num_written += (size_t)write_ret;
+               }
+
+               total += (size_t)read_ret;
+       }
+
+       SAFE_FREE(buf);
+       return (ssize_t)total;
+}
+
+static ssize_t sys_read_fn(void *file, void *buf, size_t len)
+{
+       int *fd = (int *)file;
+
+       return sys_read(*fd, buf, len);
+}
+
+static ssize_t sys_write_fn(void *file, const void *buf, size_t len)
+{
+       int *fd = (int *)file;
+
+       return sys_write(*fd, buf, len);
+}
+
+SMB_OFF_T transfer_file(int infd, int outfd, SMB_OFF_T n)
+{
+       return (SMB_OFF_T)transfer_file_internal(&infd, &outfd, (size_t)n,
+                                                sys_read_fn, sys_write_fn);
+}