The useless_ptr must be non-zero for addform and setform client functions

to work.

Note about setprinter level 1 not existing.
(This used to be commit 6367bfc4781a678923f1fba4681c9b7fc6bb9710)

diff --git a/source3/rpc_parse/parse_spoolss.c b/source3/rpc_parse/parse_spoolss.c
index 5c2dd6b48f4269be9355b9b9cbc72b8d3b0abe56..6da0c5636cacf6d962e1a372827e96273a45eb4e 100644 (file)
--- a/source3/rpc_parse/parse_spoolss.c
+++ b/source3/rpc_parse/parse_spoolss.c
@@ -3723,6 +3723,9 @@ BOOL make_spoolss_q_setprinter(TALLOC_CTX *mem_ctx, SPOOL_Q_SETPRINTER *q_u,
        q_u->info.level = level;
        q_u->info.info_ptr = (info != NULL) ? 1 : 0;
        switch (level) {
+
+         /* There's no such thing as a setprinter level 1 */
+
        case 2:
                secdesc = info->printers_2->secdesc;
                devmode = info->printers_2->devmode;
@@ -5934,7 +5937,7 @@ BOOL spoolss_io_r_deleteform(char *desc, SPOOL_R_DELETEFORM *r_u, prs_struct *ps
 
 BOOL spoolss_io_q_addform(char *desc, SPOOL_Q_ADDFORM *q_u, prs_struct *ps, int depth)
 {
-       uint32 useless_ptr=0;
+       uint32 useless_ptr=1;
        prs_debug(ps, depth, desc, "spoolss_io_q_addform");
        depth++;
 
@@ -5979,7 +5982,7 @@ BOOL spoolss_io_r_addform(char *desc, SPOOL_R_ADDFORM *r_u, prs_struct *ps, int
 
 BOOL spoolss_io_q_setform(char *desc, SPOOL_Q_SETFORM *q_u, prs_struct *ps, int depth)
 {
-       uint32 useless_ptr=0;
+       uint32 useless_ptr=1;
        prs_debug(ps, depth, desc, "spoolss_io_q_setform");
        depth++;