regulator: da9211: Hand over GPIO to regulator core
authorLinus Walleij <linus.walleij@linaro.org>
Thu, 6 Dec 2018 12:43:48 +0000 (13:43 +0100)
committerMark Brown <broonie@kernel.org>
Tue, 11 Dec 2018 01:04:37 +0000 (01:04 +0000)
The GPIO descriptors used by the DA9211 driver are retrieved
during probe() and it is really helpful to have those under
devres management because of all the errorpaths in the
intialization.

Using the new dev_gpiod_unhinge() call we can remove the
devres management of the descriptor right before handing
it over to the regulators core.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/da9211-regulator.c

index 8f68c7a05d27968970287c8811f5e1764c1ad859..109ee12d43626ce2822ba872c252000bf3e7cea1 100644 (file)
@@ -389,6 +389,12 @@ static int da9211_regulator_init(struct da9211 *chip)
                else
                        config.ena_gpiod = NULL;
 
+               /*
+                * Hand the GPIO descriptor management over to the regulator
+                * core, remove it from GPIO devres management.
+                */
+               if (config.ena_gpiod)
+                       devm_gpiod_unhinge(chip->dev, config.ena_gpiod);
                chip->rdev[i] = devm_regulator_register(chip->dev,
                        &da9211_regulators[i], &config);
                if (IS_ERR(chip->rdev[i])) {