s4-libnet: Don't call talloc_get_type() for the same struct twice.

Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>

diff --git a/source4/libnet/libnet_rpc.c b/source4/libnet/libnet_rpc.c
index 349e1f86642042948e96e93361ea87072611754e..13115288b1d37abdf5c814d590964aff77e3fc46 100644 (file)
--- a/source4/libnet/libnet_rpc.c
+++ b/source4/libnet/libnet_rpc.c
@@ -189,11 +189,11 @@ static NTSTATUS libnet_RpcConnectSrv_recv(struct composite_context *c,
                                          struct libnet_RpcConnect *r)
 {
        NTSTATUS status;
-       struct rpc_connect_srv_state *s = talloc_get_type(c->private_data,
-                                         struct rpc_connect_srv_state);
 
        status = composite_wait(c);
        if (NT_STATUS_IS_OK(status)) {
+               struct rpc_connect_srv_state *s;
+
                /* move the returned rpc pipe between memory contexts */
                s = talloc_get_type(c->private_data, struct rpc_connect_srv_state);
                r->out.dcerpc_pipe = talloc_steal(mem_ctx, s->r.out.dcerpc_pipe);