tests/krb5: Make arguments to get_target() keyword arguments

This avoids mistakes by ensuring that passed-in arguments go to their
intended destinations.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/python/samba/tests/krb5/group_tests.py b/python/samba/tests/krb5/group_tests.py
index 1090e59bea2b065da6abbd75c5a45b7507e9f185..d7f2264ebdcdb9fe3b14f136de6888c6a9fcbf45 100755 (executable)
--- a/python/samba/tests/krb5/group_tests.py
+++ b/python/samba/tests/krb5/group_tests.py
@@ -1828,7 +1828,8 @@ class GroupTests(KDCBaseTest):
         ts_enc_padata = self.get_enc_timestamp_pa_data_from_key(preauth_key)
         padata = [ts_enc_padata]
 
-        target_creds, sname = self.get_target(as_to_krbtgt, as_compression)
+        target_creds, sname = self.get_target(as_to_krbtgt,
+                                              compression=as_compression)
         decryption_key = self.TicketDecryptionKey_from_creds(target_creds)
 
         target_supported_etypes = target_creds.tgs_supported_enctypes
@@ -1914,7 +1915,8 @@ class GroupTests(KDCBaseTest):
                                            set_user_flags=tgs_set_user_flags,
                                            reset_user_flags=tgs_reset_user_flags)
 
-        target_creds, sname = self.get_target(tgs_to_krbtgt, tgs_compression)
+        target_creds, sname = self.get_target(tgs_to_krbtgt,
+                                              compression=tgs_compression)
         decryption_key = self.TicketDecryptionKey_from_creds(target_creds)
 
         subkey = self.RandomKey(ticket.session_key.etype)

diff --git a/python/samba/tests/krb5/kdc_base_test.py b/python/samba/tests/krb5/kdc_base_test.py
index 4f0725f10b333d3f6b516c27a1508d362a1a8078..5e2d7747e954dc066ec999837ea774747f3ac6b2 100644 (file)
--- a/python/samba/tests/krb5/kdc_base_test.py
+++ b/python/samba/tests/krb5/kdc_base_test.py
@@ -1825,7 +1825,7 @@ class KDCBaseTest(RawKerberosTest):
     # Get the credentials and server principal name of either the krbtgt, or a
     # specially created account, with resource SID compression either supported
     # or unsupported.
-    def get_target(self, to_krbtgt, compression=None, extra_enctypes=0):
+    def get_target(self, to_krbtgt, *, compression=None, extra_enctypes=0):
         if to_krbtgt:
             self.assertIsNone(compression,
                               "it's no good specifying compression support "