sunrpc: add _print_rpc_iostats() to output metrics for one RPC op
authorDave Wysochanski <dwysocha@redhat.com>
Tue, 10 Jul 2018 18:59:23 +0000 (14:59 -0400)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Mon, 30 Jul 2018 17:19:41 +0000 (13:19 -0400)
Refactor the output of the metrics for one RPC op into an internal
function.  No functional change.

Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
net/sunrpc/stats.c

index f68aa46c9dd7125bee03506a9a3e4914939770ae..6606d7b3113adf02f9578421b0d8a6eb55aa5331 100644 (file)
@@ -208,6 +208,21 @@ static void _print_name(struct seq_file *seq, unsigned int op,
                seq_printf(seq, "\t%12u: ", op);
 }
 
+static void _print_rpc_iostats(struct seq_file *seq, struct rpc_iostats *stats,
+                              int op, const struct rpc_procinfo *procs)
+{
+       _print_name(seq, op, procs);
+       seq_printf(seq, "%lu %lu %lu %Lu %Lu %Lu %Lu %Lu\n",
+                  stats->om_ops,
+                  stats->om_ntrans,
+                  stats->om_timeouts,
+                  stats->om_bytes_sent,
+                  stats->om_bytes_recv,
+                  ktime_to_ms(stats->om_queue),
+                  ktime_to_ms(stats->om_rtt),
+                  ktime_to_ms(stats->om_execute));
+}
+
 void rpc_print_iostats(struct seq_file *seq, struct rpc_clnt *clnt)
 {
        struct rpc_iostats *stats = clnt->cl_metrics;
@@ -229,17 +244,7 @@ void rpc_print_iostats(struct seq_file *seq, struct rpc_clnt *clnt)
 
        seq_printf(seq, "\tper-op statistics\n");
        for (op = 0; op < maxproc; op++) {
-               struct rpc_iostats *metrics = &stats[op];
-               _print_name(seq, op, clnt->cl_procinfo);
-               seq_printf(seq, "%lu %lu %lu %Lu %Lu %Lu %Lu %Lu\n",
-                               metrics->om_ops,
-                               metrics->om_ntrans,
-                               metrics->om_timeouts,
-                               metrics->om_bytes_sent,
-                               metrics->om_bytes_recv,
-                               ktime_to_ms(metrics->om_queue),
-                               ktime_to_ms(metrics->om_rtt),
-                               ktime_to_ms(metrics->om_execute));
+               _print_rpc_iostats(seq, &stats[op], op, clnt->cl_procinfo);
        }
 }
 EXPORT_SYMBOL_GPL(rpc_print_iostats);