Add note about racy tests

diff --git a/lib/gssapi/krb5/test_kcred.c b/lib/gssapi/krb5/test_kcred.c
index f53ce783bb071e9e1b71d82b4322f79e047201cf..3cbba243f0b86c508ca58741ca6855e0e5429c06 100644 (file)
--- a/lib/gssapi/krb5/test_kcred.c
+++ b/lib/gssapi/krb5/test_kcred.c
@@ -90,7 +90,8 @@ copy_import(void)
     if (!equal)
        errx(1, "names not equal");
 
-    if (lifetime1 != lifetime1)
+    /* FIXME: This check is racy! */
+    if (lifetime1 != lifetime2)
        errx(1, "lifetime not equal");
 
     if (usage1 != usage1)

diff --git a/lib/gssapi/test_kcred.c b/lib/gssapi/test_kcred.c
index a22d4ec9b8be75d05b5b2acff396463f1e9cfedb..866ee78ecf1fcfdd161321c8fd1b615be09d34c8 100644 (file)
--- a/lib/gssapi/test_kcred.c
+++ b/lib/gssapi/test_kcred.c
@@ -102,6 +102,7 @@ copy_import(void)
     if (!equal)
        errx(1, "names not equal");
 
+    /* FIXME: This check is racy! */
     if (lifetime1 != lifetime2)
        errx(1, "lifetime not equal %lu != %lu",
             (unsigned long)lifetime1, (unsigned long)lifetime2);
@@ -126,6 +127,7 @@ copy_import(void)
     if (!equal)
        errx(1, "names not equal");
 
+    /* FIXME: This check is racy! */
     if (lifetime1 != lifetime2)
        errx(1, "lifetime not equal %lu != %lu",
             (unsigned long)lifetime1, (unsigned long)lifetime2);