arch/frv/mb93090-mb00/pci-frv.c: fix build warning
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>
Fri, 24 Feb 2017 23:00:11 +0000 (15:00 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 25 Feb 2017 01:46:56 +0000 (17:46 -0800)
The build of frv defconfig gives warning:

  arch/frv/mb93090-mb00/pci-frv.c:176:5: warning: ignoring return value of 'pci_assign_resource', declared with attribute warn_unused_result

Just print an error message to silence the warning.  We can not do much
here on error.

Link: http://lkml.kernel.org/r/1484256471-5379-1-git-send-email-sudipm.mukherjee@gmail.com
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/frv/mb93090-mb00/pci-frv.c

index 34bb4b13e079811f79e76598119c272625f774db..c452ddb5620f220d0a3d35ead88e42f9eaad5ff8 100644 (file)
@@ -147,7 +147,7 @@ static void __init pcibios_allocate_resources(int pass)
 static void __init pcibios_assign_resources(void)
 {
        struct pci_dev *dev = NULL;
-       int idx;
+       int idx, err;
        struct resource *r;
 
        for_each_pci_dev(dev) {
@@ -172,8 +172,13 @@ static void __init pcibios_assign_resources(void)
                         *  the BIOS forgot to do so or because we have decided the old
                         *  address was unusable for some reason.
                         */
-                       if (!r->start && r->end)
-                               pci_assign_resource(dev, idx);
+                       if (!r->start && r->end) {
+                               err = pci_assign_resource(dev, idx);
+                               if (err)
+                                       dev_err(&dev->dev,
+                                               "Failed to assign new address to %d\n",
+                                               idx);
+                       }
                }
        }
 }