RDMA/bnxt_re: Fix an error code in bnxt_qplib_create_srq()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 30 Jan 2018 20:40:30 +0000 (23:40 +0300)
committerDoug Ledford <dledford@redhat.com>
Wed, 31 Jan 2018 21:19:50 +0000 (16:19 -0500)
We should return -ENOMEM if the allocation fails.  (The current code
returns succees).

Fixes: 37cb11acf1f7 ("RDMA/bnxt_re: Add SRQ support for Broadcom adapters")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-By: Devesh Sharma <devesh.sharma@broadcom.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/hw/bnxt_re/qplib_fp.c

index 8b5f11ac0e42ced6606ce4ae85abc5b881ef6b37..1b0e94697fe34ceea2f7218deb394944458fcc78 100644 (file)
@@ -557,8 +557,10 @@ int bnxt_qplib_create_srq(struct bnxt_qplib_res *res,
 
        srq->swq = kcalloc(srq->hwq.max_elements, sizeof(*srq->swq),
                           GFP_KERNEL);
-       if (!srq->swq)
+       if (!srq->swq) {
+               rc = -ENOMEM;
                goto fail;
+       }
 
        RCFW_CMD_PREP(req, CREATE_SRQ, cmd_flags);