efi/x86: Set the PE/COFF header's NX compat flag unconditionally
authorArd Biesheuvel <ardb@kernel.org>
Tue, 16 Jan 2024 08:53:48 +0000 (09:53 +0100)
committerBorislav Petkov (AMD) <bp@alien8.de>
Wed, 28 Feb 2024 13:23:55 +0000 (14:23 +0100)
Now that the proper section and file alignment is used, and the EFI
memory attributes protocol to manage executable permissions where needed
is invoked, set the NX compat flag unconditionally.

  [ bp: Remove the "we"s. ]

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/20240116085347.2193966-2-ardb+git@google.com
arch/x86/boot/header.S

index a1bbedd989e42ed5f9e433f556613613094ae74d..b5c79f43359bcde2c4c3c5ed796e8780f7979774 100644 (file)
@@ -111,11 +111,7 @@ extra_header_fields:
        .long   salign                          # SizeOfHeaders
        .long   0                               # CheckSum
        .word   IMAGE_SUBSYSTEM_EFI_APPLICATION # Subsystem (EFI application)
-#ifdef CONFIG_EFI_DXE_MEM_ATTRIBUTES
        .word   IMAGE_DLL_CHARACTERISTICS_NX_COMPAT     # DllCharacteristics
-#else
-       .word   0                               # DllCharacteristics
-#endif
 #ifdef CONFIG_X86_32
        .long   0                               # SizeOfStackReserve
        .long   0                               # SizeOfStackCommit