pwm: bcm2835: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Wed, 26 Aug 2020 14:47:42 +0000 (16:47 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Thu, 24 Sep 2020 07:18:10 +0000 (09:18 +0200)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-bcm2835.c

index d78f86f8e46210e7072558bd119f27f8f20cac95..6841dcfe27fc8cdf3fd8bedab42022c3bb85d21a 100644 (file)
@@ -152,13 +152,9 @@ static int bcm2835_pwm_probe(struct platform_device *pdev)
                return PTR_ERR(pc->base);
 
        pc->clk = devm_clk_get(&pdev->dev, NULL);
-       if (IS_ERR(pc->clk)) {
-               ret = PTR_ERR(pc->clk);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(&pdev->dev, "clock not found: %d\n", ret);
-
-               return ret;
-       }
+       if (IS_ERR(pc->clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(pc->clk),
+                                    "clock not found\n");
 
        ret = clk_prepare_enable(pc->clk);
        if (ret)