mtd: rawnand: lpc32xx_mlc: fix the probe function error path
authorMiquel Raynal <miquel.raynal@bootlin.com>
Sat, 21 Apr 2018 18:00:41 +0000 (20:00 +0200)
committerBoris Brezillon <boris.brezillon@bootlin.com>
Sun, 29 Apr 2018 06:56:45 +0000 (08:56 +0200)
An error after nand_scan_tail() should trigger a nand_cleanup() and not
a nand_release(). The latter doing an mtd_device_unregister() which is
not needed if mtd_device_register() failed.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
drivers/mtd/nand/raw/lpc32xx_mlc.c

index 6e31faf2f07f31a974ef1c446a061b517be3a43d..052d123a8304074c8a64ab158dc496bc60fbce31 100644 (file)
@@ -806,12 +806,12 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
        res = mtd_device_register(mtd, host->ncfg->parts,
                                  host->ncfg->num_parts);
        if (res)
-               goto release_nand;
+               goto cleanup_nand;
 
        return 0;
 
-release_nand:
-       nand_release(mtd);
+cleanup_nand:
+       nand_cleanup(nand_chip);
 free_irq:
        free_irq(host->irq, host);
 release_dma_chan: