Staging: octeon: don't ignore request_irq() return code
authorRoel Kluin <roel.kluin@gmail.com>
Fri, 18 Sep 2009 19:59:22 +0000 (12:59 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 11 Dec 2009 20:23:16 +0000 (12:23 -0800)
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: David Daney <ddaney@caviumnetworks.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/octeon/ethernet-rgmii.c

index 8704133fe1272c03964dc110fa48c39b51d4b394..fbaa465d2fac3e2424d81f92d1a446b9cb107133 100644 (file)
@@ -308,7 +308,7 @@ int cvm_oct_rgmii_init(struct net_device *dev)
 
        /*
         * Due to GMX errata in CN3XXX series chips, it is necessary
-        * to take the link down immediately whne the PHY changes
+        * to take the link down immediately when the PHY changes
         * state. In order to do this we call the poll function every
         * time the RGMII inband status changes.  This may cause
         * problems if the PHY doesn't implement inband status
@@ -317,6 +317,8 @@ int cvm_oct_rgmii_init(struct net_device *dev)
        if (number_rgmii_ports == 0) {
                r = request_irq(OCTEON_IRQ_RML, cvm_oct_rgmii_rml_interrupt,
                                IRQF_SHARED, "RGMII", &number_rgmii_ports);
+               if (r != 0)
+                       return r;
        }
        number_rgmii_ports++;