samba_spnupdate: do not interpret failure count as unix error code
authorBob Campbell <bobcampbell@catalyst.net.nz>
Fri, 3 Jun 2016 02:32:10 +0000 (14:32 +1200)
committerDouglas Bagnall <dbagnall@samba.org>
Fri, 3 Jun 2016 09:02:26 +0000 (11:02 +0200)
Signed-off-by: Bob Campbell <bobcampbell@catalyst.net.nz>
Pair-programmed-with: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Fri Jun  3 11:02:26 CEST 2016 on sn-devel-144

source4/dsdb/dns/dns_update.c

index 0c0e4b4512e4a59388b17bb915e58634c18519de..0591e346824720c470fc353b20e0bb54f1a20e63 100644 (file)
@@ -309,14 +309,8 @@ static void dnsupdate_spnupdate_done(struct tevent_req *subreq)
        ret = samba_runcmd_recv(subreq, &sys_errno);
        TALLOC_FREE(subreq);
        if (ret != 0) {
-               service->nameupdate.status = map_nt_error_from_unix_common(sys_errno);
-       } else {
-               service->nameupdate.status = NT_STATUS_OK;
-       }
-
-       if (!NT_STATUS_IS_OK(service->nameupdate.status)) {
-               DEBUG(0,(__location__ ": Failed SPN update - %s\n",
-                        nt_errstr(service->nameupdate.status)));
+               DEBUG(0,(__location__ ": Failed SPN update - with error code %d\n",
+                        sys_errno));
        } else {
                DEBUG(3,("Completed SPN update check OK\n"));
        }