platform/x86: amd-pmc: Fix undefined reference to __udivdi3
authorShyam Sundar S K <Shyam-sundar.S-k@amd.com>
Fri, 16 Jul 2021 15:38:02 +0000 (21:08 +0530)
committerHans de Goede <hdegoede@redhat.com>
Sat, 17 Jul 2021 10:16:34 +0000 (12:16 +0200)
It was reported that on i386 config

------
on i386:

ld: drivers/platform/x86/amd-pmc.o: in function `s0ix_stats_show':
amd-pmc.c:(.text+0x100): undefined reference to `__udivdi3'
-------

The reason for this is that 64-bit integer division is not supported
on 32-bit architecture. Use do_div macro to fix this.

Fixes: b9a4fa6978be ("platform/x86: amd-pmc: Add support for logging s0ix counters")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org> # and build-tested
Link: https://lore.kernel.org/r/20210716153802.2929670-1-Shyam-sundar.S-k@amd.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/amd-pmc.c

index 663a4ca0580d2c311aa0a263a0f47424fd854af1..3481479a2942fd8010be5e929c39586b20a7349c 100644 (file)
@@ -189,7 +189,8 @@ static int s0ix_stats_show(struct seq_file *s, void *unused)
        exit_time = exit_time << 32 | ioread32(dev->fch_virt_addr + FCH_S0I3_EXIT_TIME_L_OFFSET);
 
        /* It's in 48MHz. We need to convert it */
-       residency = (exit_time - entry_time) / 48;
+       residency = exit_time - entry_time;
+       do_div(residency, 48);
 
        seq_puts(s, "=== S0ix statistics ===\n");
        seq_printf(s, "S0ix Entry Time: %lld\n", entry_time);