libsmb: Fix a signed/unsigned warning

"num_bytes" is uint32_t, "received" is uint16_t. The multiplication
seems to implicitly widen "received" to int, leading to a
signed/unsigned warning. This cast makes that warning go away.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/source3/libsmb/clilist.c b/source3/libsmb/clilist.c
index 59404bce7bf77d33c08df7bdc566d917075417e3..57fefdc382a6a5a020250375999ad6406b990053 100644 (file)
--- a/source3/libsmb/clilist.c
+++ b/source3/libsmb/clilist.c
@@ -465,7 +465,7 @@ static void cli_list_old_done(struct tevent_req *subreq)
                 * I don't think this can wrap. received is
                 * initialized from a 16-bit value.
                 */
-               if (num_bytes < (received * DIR_STRUCT_SIZE + 3)) {
+               if (num_bytes < ((uint32_t)received * DIR_STRUCT_SIZE + 3)) {
                        TALLOC_FREE(subreq);
                        tevent_req_nterror(
                                req, NT_STATUS_INVALID_NETWORK_RESPONSE);