r565: Uninitialized data fixes from kawasa_r@itg.hitachi.co.jp.

Jeremy.
(This used to be commit c23a73324b335e42877551283b274f6d12f2c1a7)

diff --git a/source3/nsswitch/wb_client.c b/source3/nsswitch/wb_client.c
index 5d431392450f9b561915cffa7478bca953487c49..a1c71becf03d47700d6c34140441e2e3bcdb8352 100644 (file)
--- a/source3/nsswitch/wb_client.c
+++ b/source3/nsswitch/wb_client.c
@@ -270,6 +270,7 @@ static int wb_getgroups(const char *user, gid_t **groups)
 
        /* Call winbindd */
 
+       ZERO_STRUCT(request);
        fstrcpy(request.data.username, user);
 
        ZERO_STRUCT(response);

diff --git a/source3/nsswitch/winbindd_group.c b/source3/nsswitch/winbindd_group.c
index 4800ab20cfacdbe354ad3936be4fdb196b4c8044..7b4529144e270172dfa8bb0781a35d6bbaf023f4 100644 (file)
--- a/source3/nsswitch/winbindd_group.c
+++ b/source3/nsswitch/winbindd_group.c
@@ -631,6 +631,9 @@ enum winbindd_result winbindd_getgrent(struct winbindd_cli_state *state)
             malloc(num_groups * sizeof(struct winbindd_gr))) == NULL)
                return WINBINDD_ERROR;
 
+       memset(state->response.extra_data, '\0',
+               num_groups * sizeof(struct winbindd_gr) );
+
        state->response.data.num_entries = 0;
 
        group_list = (struct winbindd_gr *)state->response.extra_data;

diff --git a/source3/nsswitch/winbindd_pam.c b/source3/nsswitch/winbindd_pam.c
index c1840b605337a9a03290975547bd7a56b025e168..25f53e7a535c3c4f97c33f83e826f8877a1d93b3 100644 (file)
--- a/source3/nsswitch/winbindd_pam.c
+++ b/source3/nsswitch/winbindd_pam.c
@@ -48,6 +48,7 @@ static NTSTATUS append_info3_as_ndr(TALLOC_CTX *mem_ctx,
                prs_mem_free(&ps);
                return NT_STATUS_NO_MEMORY;
        }
+       memset( state->response.extra_data, '\0', size );
        prs_copy_all_data_out(state->response.extra_data, &ps);
        state->response.length += size;
        prs_mem_free(&ps);