powerpc/pseries/cmm: Implement release() function for sysfs device
authorDavid Hildenbrand <david@redhat.com>
Thu, 31 Oct 2019 14:29:22 +0000 (15:29 +0100)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 13 Nov 2019 05:58:00 +0000 (16:58 +1100)
When unloading the module, one gets
  ------------[ cut here ]------------
  Device 'cmm0' does not have a release() function, it is broken and must be fixed. See Documentation/kobject.txt.
  WARNING: CPU: 0 PID: 19308 at drivers/base/core.c:1244 .device_release+0xcc/0xf0
  ...

We only have one static fake device. There is nothing to do when
releasing the device (via cmm_exit()).

Signed-off-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20191031142933.10779-2-david@redhat.com
arch/powerpc/platforms/pseries/cmm.c

index b33251d75927bceeb5a3a70b11fd3aae0c0a88ee..572651a5c87bbd63aaec5a51e2e5547c0dc4d750 100644 (file)
@@ -411,6 +411,10 @@ static struct bus_type cmm_subsys = {
        .dev_name = "cmm",
 };
 
+static void cmm_release_device(struct device *dev)
+{
+}
+
 /**
  * cmm_sysfs_register - Register with sysfs
  *
@@ -426,6 +430,7 @@ static int cmm_sysfs_register(struct device *dev)
 
        dev->id = 0;
        dev->bus = &cmm_subsys;
+       dev->release = cmm_release_device;
 
        if ((rc = device_register(dev)))
                goto subsys_unregister;